artisan firefly:use-encryption doesn't decrypt soft-deleted records

[hamuz]

Bug description I am running Firefly III version 4.7.7

(please give a clear and concise description of what the bug is)

Steps to reproduce What do you need to do to trigger this bug?

1. Create new account
2. Delete account
3. set USE_ENCRYPTION to false in your .env file
4. php artisan firefly:use-encryption.
5. Inspect DB and witness name is still encrypted

Expected behavior What do you expect to see after those steps? Even deleted records should be decrypted.

[JC5]

Not sure what the point would be but it’s an easy change.

[hamuz]

It's part of your instructions in #1789 in changing keys. When setting the new key, it would be beneficial to encrypt also the deleted records, otherwise, they'll become inaccessible (if you don't backup old key). This would allow in the future option to "recover" or "un-delete" some stuff if the project goes that way.

[JC5]

Like I said, it's an easy change :wink:

[JC5]

... when you don't forget to push the change :grin:. See my commit above this reply.

[hamuz]

This isn't fixed, see stacktrace below (latestest develop + my PR):

ERROR: Call to undefined method Illuminate\Database\Eloquent\Builder::withDeleted() {"exception":"[object] (BadMethodCallException(code: 0): Call to undefined method Illuminate\\Database\\Eloquent\\Builder::withDeleted() at /app/vendor/laravel/framework/src/Illuminate/Support/Traits/ForwardsCalls.php:50)
[stacktrace]
#0 /app/vendor/laravel/framework/src/Illuminate/Support/Traits/ForwardsCalls.php(36): Illuminate\\Database\\Eloquent\\Builder::throwBadMethodCallException('withDeleted')
#1 /app/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1321): Illuminate\\Database\\Eloquent\\Builder->forwardCallTo(Object(Illuminate\\Database\\Query\\Builder), 'withDeleted', Array)
#2 /app/app/Console/Commands/UseEncryption.php(82): Illuminate\\Database\\Eloquent\\Builder->__call('withDeleted', Array)
#3 /app/app/Console/Commands/UseEncryption.php(59): FireflyIII\\Console\\Commands\\UseEncryption->handleObjects('Account', 'name', 'encrypted')
#4 [internal function]: FireflyIII\\Console\\Commands\\UseEncryption->handle()

[JC5]

Fixed now.