firefly-iii / firefly-iii

Firefly III: a personal finances manager
https://firefly-iii.org/
GNU Affero General Public License v3.0
16.37k stars 1.48k forks source link

API: v1/transactions GET end not respected #7974

Closed dreautall closed 1 year ago

dreautall commented 1 year ago

Support guidelines

I've found a bug and checked that ...

Description

The "end" parameter of the v1/transaction GET query is not respected.

As you disabled cURL for the demo site, here a quick screenshot from the API doc site :D

image

See "date" of the first shown result being 2023-09-20, but the requested "end" is 2023-09-18.

Debug information

Demo Page

Expected behaviour

No response

Steps to reproduce

No response

Additional info

Reported by @zynexiz in https://github.com/dreautall/waterfly-iii/issues/144

JC5 commented 1 year ago

That's weird, the code is so basic. I'll check it out!

And yes the curl user agent is blocked but it's easy to circumvent :wink:

JC5 commented 1 year ago

API 2.0.9 (next release) should respect this. In all earlier API's, a start date needs to be present, even if it's 1900-01-01.

dreautall commented 1 year ago

thank you for fixing it and providing the work around, I will implement this for old API versions.

github-actions[bot] commented 1 year ago

Hi there! This is an automatic reply. Share and enjoy

This issue is now 🔒 closed. Please be aware that closed issues are not watched.

Thank you for your contributions.