firefly-iii / firefly-iii

Firefly III: a personal finances manager
https://firefly-iii.org/
GNU Affero General Public License v3.0
15.03k stars 1.37k forks source link

Inconsistencies with the start of the week #8983

Open ryester19 opened 1 month ago

ryester19 commented 1 month ago

Support guidelines

I've found a bug and checked that ...

Description

View range set in Layout Preferences: One week

When in a new browser session, Firefly III use to open up to the first day of the week being Monday. Now, it opens up to the first weekday being Sunday. This initially messes up the display of the "Left to spend" tile when you're using weekly budgets.

Example: Today's date: 6/18/2024 Date range upon load in new browser session: June 16th, 2024 - June 22nd, 2024 Date range when you select "Today" from the drop-down: June 17th, 2024 - June 23rd, 2024

Reproducible in both Firefox and Edge

Debug information

Debug information generated at 2024-06-18 09:11:35 for Firefly III version v6.1.18.

System information
ItemValue
Firefly III6.1.18 / v2.1.0 / 24 (exp. 24)
PHP version8.3.8 (64bits) / apache2handler / Linux x86_64
BCscale12
Error reportingDisplay: Off, reporting: ALL errors
Max upload67108864 (64 MB)
Database driversmysql, *pgsql*, sqlite,
Docker build#1104, base #85
Firefly III information
ItemValue
TimezoneAmerica/New_York + America/New_York
App environmentproduction, debug: false
Layoutv1
Logginginfo, stack / (empty)
Cache driverfile
Default language and localeen_US + equal
Trusted proxies**
Login provider & user guardeloquent / web
Login headersN/A + N/A
Stateful domains
Last cron job2024-06-18 11:51:27 (1 hour ago)
Mailersmtp
User-specific information
ItemValue
User#1 of 1
User flags:pig: :wrench: :bookmark_tabs: :email:
Session start2024-06-17 09:10:58
Session end2024-06-23 09:10:58
View range1W
User languageen_US
User localeen_US
Locale(s) supporteden_US.utf8: :white_check_mark:
en_US.UTF-8: :white_check_mark:
User agentMozilla/5.0 (Windows NT 10.0; Win64; x64; rv:126.0) Gecko/20100101 Firefox/126.0

Expected behaviour

The date range should start on a Monday when View range is set to "One week". Technically not correct for the USA, but Monday seems to be what other components thinks the start of the week is.

Steps to reproduce

1) Set view range in your preferences to "One week" 2) Reload Firefly III in new browser session

Additional info

No response

JC5 commented 1 month ago

Mmm, I see this too, but I can't replicate it locally. I'll check it out.

github-actions[bot] commented 1 month ago

Hi there!

This is an automatic reply. Share and enjoy

This issue has been marked as being in triage. The root cause is not known yet, or the issue needs more investigation. You can help by sharing debug information (from /debug) if you also have this issue or when you haven't already done so.

Thank you for your contributions.