Reconcile calculates wrong difference if the timespan has been partially reconciled before.

goebeler commented 1 month ago

Support guidelines

[X] I've read the support guidelines

I've found a bug and checked that ...

[X] ... the documentation does not mention anything about my problem
[X] ... there are no open or closed issues that are related to my problem
[X] ... it's definitely a Firefly III issue, not me

Description

Reconcile ignores transaction values that have been reconciled before which leads to a wrong difference being calculated.

Debug information

Debug information generated at 2024-09-29 17:57:01 for Firefly III version v6.1.19.

System information
Item	Value
Firefly III	6.1.19 / v2.1.0 / 24 (exp. 24)
PHP version	8.3.9 (64bits) / apache2handler / Linux x86_64
BCscale	12
Error reporting	Display: Off, reporting: ALL errors
Max upload	67108864 (64 MB)
Database drivers	mysql, *pgsql*, sqlite,
Docker build	#1113, base #86

Firefly III information
Item	Value
Timezone	Europe/Berlin + Europe/Berlin
App environment	production, debug: false
Layout	v1
Logging	notice, stack / (empty)
Cache driver	file
Default language and locale	de_DE + equal
Trusted proxies	**
Login provider & user guard	eloquent / web
Login headers	N/A + N/A
Stateful domains
Last cron job	never (never)
Mailer	log

User-specific information
Item	Value
User	#1 of 1
User flags
Session start	2015-05-04 15:22:00
Session end	2024-09-29 15:22:00
View range	1M
User language	de_DE
User locale	de_DE
Locale(s) supported	de_DE.utf8: :white_check_mark: de_DE.UTF-8: :white_check_mark:
User agent	Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36

Expected behaviour

It should consider all transactions regardless if they have been reconciled before and calculate a correct difference

Steps to reproduce

have some transactions (let's assume 2 weeks for this example)
start reconcile
set the time span to include the first week
enter the start and end ballance, everything looks right
mark all transactions as correct
save the state
restart reconcile
set the time span two the whole 2 weeks (including the week you just did in the steps before)
even if all transactions are actually complete and correct, the UI is going to show a difference that amounts exactly to the sum of all transactions that have been reconciled in the first round. They seem to be ignored for the calculatino eventhough they belong to the timespan.

Additional info

No response

JC5 commented 1 month ago

Nice, thanks for opening an issue! I'll check it out.

github-actions[bot] commented 1 month ago

Hi there!

This is an automatic reply. Share and enjoy

This issue has been marked as being in triage. The root cause is not known yet, or the issue needs more investigation. You can help by sharing debug information (from /debug) if you also have this issue or when you haven't already done so.

Thank you for your contributions.

firefly-iii / firefly-iii