firefox-devtools / debugger

The faster and smarter Debugger for Firefox DevTools 🔥🦊🛠
https://firefox-dev.tools/
4.61k stars 759 forks source link

📷 Create Storybook Stories for our Components #2881

Closed jasonLaster closed 7 years ago

jasonLaster commented 7 years ago

We've recently adopted storybook and percy for visually testing our components. The stories are written like unit tests and are available in the storybook viewer yarn storybook. It would be great if we could write storybook stories for all of our components. This will help us have a great environment for UI development and stop visual regressions from happening.

Example

  storiesOf("Frames", module)
    .add(`simple frame (${optionLabel})`, () => {
      const frame = {
        id: 1,
        source: { url: "foo-view.js" },
        displayName: "renderFoo",
        library: false,
        location: { line: 10, url: "foo-view.js" }
      };

      return FrameFactory({ frame }, option);
    })

GIF

Checklist

jasonLaster commented 7 years ago

We now have many stories which is great, i'm going to close the tracking issue