firefox-devtools / debugger

The faster and smarter Debugger for Firefox DevTools 🔥🦊🛠
https://firefox-dev.tools/
4.61k stars 759 forks source link

[Outline] Include icons from DevIcons #4141

Closed jasonLaster closed 6 years ago

jasonLaster commented 6 years ago

It would be sweet to use a consistent set of icons as Atom. This is a two step process:

  1. setup a font-loader in webpack for base64 encoding fonts
  2. pull in octicons

Here are some links

jasonLaster commented 6 years ago

and here are the SVGs: https://github.com/vorillaz/devicons/tree/master/!SVG

jasonLaster commented 6 years ago

here are octicon icons: https://github.com/primer/octicons

jasonLaster commented 6 years ago

Screen Shot 2017-10-10 at 10.12.12 AM.png

and here's where the octicons font lives: /Applications/Atom.app/Contents/Resources/app/static

i still think if we figureout which svg is used, we can use that...

sliminality commented 6 years ago

/claim

claim[bot] commented 6 years ago

Thanks for claiming the issue! :wave:

Here are some link for getting setup, contributing, and development tips. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

:fox_face: Debugger team!

jasonLaster commented 6 years ago

The goal here is to re-use atom's function and class icons:

sliminality commented 6 years ago

Do you know what Atom plugins are in the screenshot above? I was hoping to inspect the webview, since I haven't had any luck finding those exact icons from Octicons or devicons. (Unless we don't actually need to get the same ones? But I'm having trouble finding plain lambda icons, too 😛)

lukaszsobek commented 6 years ago

/claim

claim[bot] commented 6 years ago

Thanks for claiming the issue! :wave:

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

:fox_face: Debugger team!

lukaszsobek commented 6 years ago

Can this be closed, as the lambda issue is resolved, or are we going for a full icon rework?