[meta] Check that all plugins are compatible with React 16.2.0

[MikeRatcliffe]

As part "encouraging" the debugger to be React 16 compatible (issue #4879) we need to check that every dependency will work with React 16.

[MikeRatcliffe]

/claim

[claim[bot]]

Thanks for claiming the issue! :wave:

!!! Please check your email and confirm the invitation

Here are some links for getting setup, contributing, and developing. We're always happy to answer questions in slack! If you become busy, feel free to /unclaim it.

:fox_face: Debugger team!

[MikeRatcliffe]

TODO

package.json - dependencies (production)

• [x] "devtools-splitter": "^0.0.6",
• [x] "fuzzaldrin-plus": "^0.6.0",
• [x] "immutable": "^3.8.2",
• [x] "react-inlinesvg": "^0.7.4",
• [x] "react-transition-group": "^2.2.1",
• [x] "redux-saga": "^0.16.0",
• [x] "devtools-components": "^0.1.4",
• [x] "devtools-reps": "^0.19.1",
• [x] "svg-inline-react": "^3.0.0",

package.json - dependencies (dev)

• [x] "@ percy-io/percy-storybook": "^1.2.7",
• [x] "@ storybook/react": "^3.2.17",
• [ ] "react-test-renderer": "16.2.0",

Final Touches

Prod dependencies

• [ ] "react": "^16.2.0",
• [ ] "react-dom": "^16.2.0",

Dev dependencies

• [x] "enzyme": "^3.2.0",
• [ ] "enzyme-adapter-react-16": "^1.1.0", and fix Enzyme tests
• [x] "enzyme-to-json": "3.2.2",

Code Changes for the actual React 16 update

diff --git a/src/main.js b/src/main.js
index 516c9b54..8bff031b 100644
--- a/src/main.js
+++ b/src/main.js
@@ -13,9 +13,9 @@ import { isFirefoxPanel } from "devtools-config";
 import { onConnect } from "./client";
 import { teardownWorkers } from "./utils/bootstrap";

-if (process.env.NODE_ENV !== "production") {
-  window.Perf = require("react-addons-perf");
-}
+// if (process.env.NODE_ENV !== "production") {
+//   window.Perf = require("react-addons-perf");
+// }

 if (isFirefoxPanel()) {
   module.exports = {
diff --git a/src/test/tests-setup.js b/src/test/tests-setup.js
index 63aad0e6..aa2037b9 100644
--- a/src/test/tests-setup.js
+++ b/src/test/tests-setup.js
@@ -4,6 +4,12 @@ import path from "path";
 import getConfig from "../../bin/getConfig";
 import { setConfig } from "devtools-config";
 import { readFileSync } from "fs";
+
+// Setup enzyme's react adapter
+import { configure } from "enzyme";
+import Adapter from "enzyme-adapter-react-16";
+configure({ adapter: new Adapter() });
+
 const rootPath = path.join(__dirname, "../../");

 const envConfig = getConfig();

[wldcordeiro]

Decide whether to continue using Enzyme with Async Fibre on the horizon. Whatever we do here we will need to rewrite the Enzyme tests because Enzyme was rewritten for React Fibre.

Rewrite is a bit of a stretch. There may need to be tweaks here and there but for the most part unless you were using some of the private APIs in Enzyme that they've since stripped you shouldn't have the hardest time upgrading (I would even argue that what we should do is update Enzyme to 3.x first with the React 15 adapter.)

[jasonLaster]

i believe this is done