menu popup broken - Githubissues

firefox-devtools / devtools-core

:rocket: Packages for Firefox DevTools

142 stars 97 forks source link

menu popup broken #188

Open bomsy opened 7 years ago

bomsy commented 7 years ago

After the nice work which allows the launch pad to be run and developed without having to link to the debugger, the css for the menupop which currently lives in the debugger can't be found.

We need to move the styles from the debbuger to devtools-core.

menu-pop

jasonLaster commented 7 years ago

I'll look into this!

wldcordeiro commented 7 years ago

Personally I think it wouldn't hurt to use actual select boxes there over the context menu but moving the styling is a good move for reuse. 😄

rickychien commented 7 years ago

I also saw this issue in netmonitor. It looks like this https://github.com/devtools-html/debugger.html/blob/master/src/components/shared/menu.css should be moved to devtools-launchpad, right?

rickychien commented 7 years ago

After copying menu.css to netmonitor.css directly, I can see menu popup displayed but it looks weird (position is not right and expandable sub-menu overlay on main-menu.) and still doesn't work (do nothing after clicking on any menu item).

jasonLaster commented 7 years ago

Thanks @rickychien, these are a couple of things:

menu.css should be in core
windows https://github.com/devtools-html/debugger.html/issues/1942
we don't support expanding sub menus https://github.com/devtools-html/devtools-core/issues/317