search

firefox-devtools / devtools-core

:rocket: Packages for Firefox DevTools
143 stars 97 forks source link

Hot Reloading regression #195

Open wldcordeiro opened 7 years ago

wldcordeiro commented 7 years ago

Transferring issue from the debugger over thanks @irfanhudda for opening the original!

Running yarn start with "hotReloading": true gives error

ERROR in ./~/devtools-launchpad/src/utils/assert.js
Module not found: Error: Cannot resolve module 'react/lib/ReactUMDEntry/lib/ReactMount' in /home/mycomp/Projects/debugger.html/node_modules/devtools-launchpad/src/utils
 @ ./~/devtools-launchpad/src/utils/assert.js 1:316-347

After setting "hotReloading": false it gives no errors.

wldcordeiro commented 7 years ago

I found that the issue is caused by us upgrading to React 15+ and using react-hot-loader 1.x. We need to upgrade to the 3.x version (currently beta).

Here's a link to a migration. https://github.com/gaearon/react-hot-loader/tree/next-docs/docs#migration-to-30

aklt commented 7 years ago

It has been annoying me for a while that the hot reloading does not work. It would be great to address this issue as it would make everyone have a better experience fixing things in the frontend :-)

So i would like to have a go at this!

zaggy commented 7 years ago

I think it is better to wait until webpack 3 changes in PR#505 are landed and then fix HMR. As some API have changed drastically between wepack versions.

aklt commented 7 years ago

Hi @zaggy, sounds reasonable, I'll keep an eye out on PR #505, thanks!

aklt commented 7 years ago

I'll try again if I can get this running :)

Anzumana commented 6 years ago

/claim

Anzumana commented 6 years ago

@aklt would love to collab on this. msg me on slack or twitter if your up for it :)