search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.19k stars 389 forks source link

scrollbar isn't usable in main threads/timer area at the top of a profile view #1123

Closed dholbert closed 6 years ago

dholbert commented 6 years ago

(originally reported as https://bugzilla.mozilla.org/show_bug.cgi?id=1474361)

STR: Go to a gecko profile with a bunch of threads, e.g. https://perfht.ml/2L1tcDf and ensure that the thread list at the top is scrollable (i.e. there is a vertical scrollbar on the right side). Move the mouse over the scrollbar; try to click it and scroll.

Expected: scrollbar thumb highlights, is draggable with mouse Actual: the vertical time slider attached to the mouse cursor is drawn over top of the scrollbar. The scrollbar thumb is not draggable; instead, all mouse events end up on the thread timeline underneath

Both Firefox and Chrome are affected.

If you right-click the scrollbar (really hitting the thing that's blocking it) and choose "inspect", you'll see the problem -- we have an abspos element that entirely fills its container and covers up the scrollbar: <ol class="timeRulerContainer"> which has:

    position: absolute;
    top: 0;
    bottom: 0;
    left: 0;
    right: 0;

Can we give that element pointer-events:none so that it doesn't absorb clicks? That seems to fix the issue locally for me -- and I can still drag to select time-ranges, and hover markers to get tooltip text, etc.

julienw commented 6 years ago

This is likely the same as #619. I invested some time to fix this along with the other problems (especially some alignment and miscalculation problem) but couldn't find a workable solution.

Your proposal doesn't fix the misalignment issue but it seems to fix the scrollbar issue which is already something in the mean time. I think I recall there were issues with it but when trying it now I can't find any...