firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.21k stars 392 forks source link

Rename "implementation" to "frame type" #1276

Open gregtatum opened 6 years ago

gregtatum commented 6 years ago

In #1275, there is confusion over the use of "Category" for the frame's implementation. I think the term "implementation" is a bit ambiguous. Historically (I at least) have avoided using it in the UI since I felt that users wouldn't know what that meant exactly. I think a more precise word that can be used both internally and in the UI could be "frame type". These frame types would be would be:

Then instead of an "implementation filter" we could have a "frame type filter" that would be:

I think in some conversation earlier, mstange had some nice ideas on how to know which labels are native or JS. I don't really recall what the exact rule was.

┆Issue is synchronized with this Jira Task

julienw commented 6 years ago

I don't like "implementation", I don't really like "frame type" either but it seems better, and I don't have very good ideas TBH :) Maybe something related to "execution" ?

zoepage commented 6 years ago

I like frame type as it is not as pre-occupied as implementation or execution. People might not know what this is, but I think they will learn quickly and assign their meaning to the wording.

Here I think, implementation or execution might be confusing.

gregtatum commented 5 years ago

We have a decision to move from the word "implementation" to "frame type"