firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.19k stars 388 forks source link

Profile comparison should provide profile alignment option #1748

Open acreskeyMoz opened 5 years ago

acreskeyMoz commented 5 years ago

It would be nice to be able to have control over the alignment of the two profiles once they are in the comparison view.

Two options have be suggested:

  1. Add some form of manual alignment/sliding to a given profile. So the user could slide one profile left/right
  2. Add an "Align on Marker" option which would automatically align the two profiles based on the selected marker (Similar to Florien's comparison scripts)

┆Issue is synchronized with this Jira Task

julienw commented 5 years ago

Yes I think this would be super valuable.

Dumping my current thoughts about this: put this somewhere in the initial form: automatically fetch the profile at this step and provide a list of markers and/or a previsualisation to align the profiles. Also ideally we could move back and forth between the initial form (or whatever name it has) and the visualisation (currently we lose what we entered when we press "back" after loading it).