search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.21k stars 394 forks source link

Profile comparison URLs drop their transforms #1856

Open mstange opened 5 years ago

mstange commented 5 years ago

Here's a URL that links to a profile comparison view with a "focus on function" transform applied.

Upon load, that transform gets discarded.

┆Issue is synchronized with this Jira Task

julienw commented 5 years ago

Ah thanks, indeed we should likely not pass a transformStack if we already have one defined in https://github.com/firefox-devtools/profiler/blob/dd1ef15c24e65f1b198a48ef06465709f2f22071/src/actions/receive-profile.js#L892-L909

Another possible location: https://github.com/firefox-devtools/profiler/blob/dd1ef15c24e65f1b198a48ef06465709f2f22071/src/reducers/url-state.js#L133-L134 I don't know which one I prefer yet.

Ideally I'd like to be able to make a difference between "no transform stacks are defined" and "the user removed the existing transform stacks" but I don't think that's possible with our current code.

gregtatum commented 5 years ago

I'm changing this to polish since it's not really breaking things.