search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.19k stars 388 forks source link

Add a toggle option to view unmangled asm.js & wasm C++ callstacks in profiling view? #211

Open juj opened 7 years ago

juj commented 7 years ago

Profiling Zen Garden demo with gecko profiler shows C++ function names as mangled:

geckoprofiler!UNITO-UNDERSCORE!zengarden

Currently the built-in Firefox devtools performance profiler displays these C++ callstacks as demangled:

devtoolsprofiler!UNITO-UNDERSCORE!asmjs

which is really nice and a bit more readable. It would be cool to have the same feature in perf.html, however that feature would be best to live behind a checkbox (default enabled), because it is often useful also to be able to select and copy-paste mangled function names from the profiler to a text editor to search for the hot function in compiled code, so unconditionally always showing unmangled C++ function names would lose that ability.

┆Issue is synchronized with this Jira Task

mstange commented 7 years ago

We can make this bug about the pref in the UI, and keep #167 about adding demangling support.