search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.15k stars 375 forks source link

Feature request: Add bookmarks / markers to a profile within the profiler UI #2324

Open mikeconley opened 4 years ago

mikeconley commented 4 years ago

Sometimes I'm zipping around in perf.html, and there's a section of the timeline that I want to remember to come back to, or need to refer to. It might be nice to be able to add a visual marker (maybe with a label?) to that part of the timeline so it's easy for me to find and get back to.

Video editing software like Premier and Camtasia Studio have this kind of timeline marker tool.

It might even be useful if one could publish those markers and share them. This might also make educating other people about how profiles are analyzed easier.

┆Issue is synchronized with this Jira Task

digitarald commented 4 years ago

Agreed, those would be extremely useful to leave an analysis papertrail and to not forget locations.

Do you have specific ideas on what you would you like to bookmark? Functions/stacks could be there, or highlighting specific regions or points in time.

julienw commented 4 years ago

I agree that would be super useful. We need to think through how that could be implemented and how that could look like. Such "markers" could be added like a normal marker, but maybe we'd like to highlight things in the call tree too. Or maybe that's 2 super different features.

Biboswan commented 4 years ago

Hi, I would like to work on this issue for getting started with the profiler

gregtatum commented 4 years ago

@Biboswan I'd recommend looking at "good first issue" labels (if we still have any) or a "polish" labeled bug rather than "feature". "feature" indicates that there is a lot more work involved with figuring out the UI requirements and approach.