search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.16k stars 379 forks source link

Adapt or disable meta data popover for imported profiles #2457

Open digitarald opened 4 years ago

digitarald commented 4 years ago

The data is plain wrong if something for imported. If we don't have meta data we can just hide the element. If imported profiles have some meta data, we need to adapt the dialog to show it better.

┆Issue is synchronized with this Jira Task

gregtatum commented 4 years ago

We should also invent some new data structures for imported formats. It would be nice to get more information about what it was imported from.

digitarald commented 4 years ago

Agreed, this is just short term until we want to further invest in imports. I tweaked the title.

julienw commented 4 years ago

But is that really wrong? I mean, maybe the interval is right, as is the recording time. Clearly not the rest of the data thought :-)

digitarald commented 4 years ago

I mean, maybe the interval is right, as is the recording time. Clearly not the rest of the data thought :-)

Are any of the importers try to set the meta data?

julienw commented 4 years ago

https://github.com/firefox-devtools/profiler/blob/8b95daa261a238adaa691d43b0bf019d1896c984/src/profile-logic/import/linux-perf.js#L252-L260

Clearly not :D