search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.18k stars 385 forks source link

Clean up the fallback label code for FileIO markers #3131

Open julienw opened 3 years ago

julienw commented 3 years ago

In the following code, we have some fallback code dedicated to FileIO markers: https://github.com/firefox-devtools/profiler/blob/c87e4e9127aa1f2e423dd81712cc4f829cf24e6f/src/profile-logic/marker-schema.js#L279-L289

This doesn't seem necessary nowadays as this could be implemented as a schema. The work here is:

  1. implement in gecko the schema that does this. (or check that it's implemented)
  2. remove the aforementioned fallback code
  3. add migration steps to both gecko and processed profile versioning to add the data to marker schemas from older profiles.
  4. possibly add tests if there's some missing for this case

┆Issue is synchronized with this Jira Task

Jasleen01 commented 3 years ago

Hi, I want to work on this issue. I will be very grateful if you could help me in solving it!

julienw commented 3 years ago

As we discussed on Matrix, this is probably a bit too complex for a first-time contributor. So this is still up for grabs.

Jasleen01 commented 3 years ago

Ok sir, got it.. Thanks! :)