search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.13k stars 372 forks source link

Add "Remove Firefox Profiler Menu Button" to profiler.firefox.com landing page #3238

Open squelart opened 3 years ago

squelart commented 3 years ago

See issue #3184 for the reason (users may not know how to remove the profiler button).

Since https://profiler.firefox.com is the main page used to initially add the toolbar button, and it knows not to show the "Enable..." button anymore after it has been enabled, I would suggest that the same button area be reused to allow easy removal of the profiler toolbar button. This would make the page a bit more consistent before and after. And I think it would be one of the most obvious location where users would look at to remove the toolbar button when no longer needed.

Enable button: profiler-enable

Suggested "Remove" button: profiler-remove

┆Issue is synchronized with this Jira Task

julienw commented 3 years ago

I'm not convinced with this solution. The most prominent button should be the most probable action a user will do.

However we can maybe add such a button in a less prominent place. But that would need a Gecko patch too, because these actions are implemented in the WebChannel implementation.

It may be easier to show a message when the user enables the button explaining how to remove it? Or put this somewhere in the documentation simply?

gregtatum commented 3 years ago

A less prominent button would be an ideal solution. I agree that it can be confusing.

Here's where the Gecko code lives: https://searchfox.org/mozilla-central/search?q=ENABLE_MENU_BUTTON&path=&case=false&regexp=false

It requires touching Gecko code, but I don't think it'd actually be a ton of work.

tripathi-abhishek commented 3 years ago

I wish to solve this issue. Please tell me what I would need. Just an overview. But don't assign me yet.