firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.17k stars 382 forks source link

Merged threads should show originating thread in tooltip #3929

Open gregtatum opened 2 years ago

gregtatum commented 2 years ago

https://share.firefox.dev/3t1SsS2

My use case was I was profiling a new feature I'm working on, that calls out into OS-libraries on a background thread. I didn't really know where and what this work was doing, so I recorded all threads, tediously cmd clicked all the threads in the process for a merged view, then I started dropping samples until I found the code I was looking for. After this, I couldn't find where my samples were coming from, and I wanted to know the specific thread. It would be nice if this information were in the tooltip or sidebar.

┆Issue is synchronized with this Jira Task

gregtatum commented 2 years ago

Nazim mentioned from chat:

yeah, that was one of the things we discussed recently. right now, there is no way of knowing which thread a sample/marker is coming from in the merged threads 😕 we should have a better handling for them but even though we add the origin threads for samples, probably it's going to be a problem to display them in the call tree/frame graph since we aggregate all the samples and that call node can include samples from multiple threads we can show the list of them maybe