search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.18k stars 385 forks source link

Share Profile should not upload for profiles loaded via from-url #456

Open digitarald opened 7 years ago

digitarald commented 7 years ago

Problem: The file could be intentionally shared as short-lived file URL with expiration. Of course saving the file could still happen; but Share URL is a quick reflex for remotely working through a profile.

The shortlink can be generated using the URL.

┆Issue is synchronized with this Jira Task

julienw commented 7 years ago

I don't think we should remove the functionality. What do you think @gregtatum ?

mstange commented 7 years ago

The UI challenge here is that, at the moment, the buttons "Share Profile" and "Permalink" are exclusive: If the profile is coming from a local source, it doesn't make sense to generate a permalink for it. However, in the from-url case, you really want both buttons to be available: "Share profile" if you want to re-upload the profile to the profile store, and "Permalink" if you just want a short url for the current selection. I don't know what the solution should be here. Just have both buttons visible if we're on a from-url URL?

digitarald commented 7 years ago

I'd give it a try to propose a UI that splits the 2 use cases.

On Tue, Jul 18, 2017, 11:20 Markus Stange notifications@github.com wrote:

The UI challenge here is that, at the moment, the buttons "Share Profile" and "Permalink" are exclusive: If the profile is coming from a local source, it doesn't make sense to generate a permalink for it. However, in the from-url case, you really want both buttons to be available: "Share profile" if you want to re-upload the profile to the profile store, and "Permalink" if you just want a short url for the current selection. I don't know what the solution should be here. Just have both buttons visible if we're on a from-url URL?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/devtools-html/perf.html/issues/456#issuecomment-316151672, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAhlxb_Qn_B6qsIw_pi8ouqbEjyAsUGks5sPPdzgaJpZM4ObpQF .