search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.19k stars 389 forks source link

Improve performance when inverting or un-inverting the callstack #467

Open violasong opened 7 years ago

violasong commented 7 years ago

Boris says it's pretty slow. Markus says #337 may help with this.

┆Issue is synchronized with this Jira Task

julienw commented 7 years ago

Here is a profile where I invert/uninvert several times: https://perfht.ml/2wfQBxf A lot of time seems to be spent in getCallNodeInfo.

I'm trying to confirm from a prod build.

julienw commented 7 years ago

This profile is better: https://perfht.ml/2ydxAsK

Especially we spend time in https://github.com/devtools-html/perf.html/blob/a40a1ec19131e2e09821f8ac0b43fc3a3a6d2186/src/profile-logic/profile-data.js#L640 which isn't especially surprising :)

gregtatum commented 7 years ago

https://perfht.ml/2x7I6Da

Here's that profile zoomed in and data transformed (that was fun).

fqueze commented 3 years ago

When looking at https://share.firefox.dev/2TYWD2w clicking the "Full range" button blocks the UI for ~25s on my macbook pro.