search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Move the stack information before the category breakdown in the flame… #4969

Closed julienw closed 1 month ago

julienw commented 2 months ago

…graph tooltip

This came from a suggestion from @fqueze. What do you think @mstange @canova ?

Deploy preview / main branch

fqueze commented 2 months ago

Playing with the deploy preview, I noticed that the colors of the two horizontal lines in the tooltip are not the same. The horizontal line immediately above the category breakdown is in a lighter grey color.

julienw commented 2 months ago

Playing with the deploy preview, I noticed that the colors of the two horizontal lines in the tooltip are not the same. The horizontal line immediately above the category breakdown is in a lighter grey color.

yeah, I noticed that too, this was also like that before. And then I decided this was good: the darker grey separates the header from the content, while the lighter grey separates the different sections in the content.

fqueze commented 2 months ago

the darker grey separates the header from the content, while the lighter grey separates the different sections in the content.

Even after reading this explanation (which sounds reasonable), it visually looks like a bug to my eyes. It's also not consistent with the network marker tooltips that also have two horizontal lines, of the same color.

julienw commented 2 months ago

Oki I start to be convinced, let me change that quickly.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.45%. Comparing base (1c699a2) to head (a9daf01).

:exclamation: Current head a9daf01 differs from pull request most recent head 585341d. Consider uploading reports for the commit 585341d to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4969 +/- ## ========================================== - Coverage 88.45% 88.45% -0.01% ========================================== Files 304 304 Lines 27317 27309 -8 Branches 7377 7372 -5 ========================================== - Hits 24164 24156 -8 Misses 2931 2931 Partials 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mstange commented 2 months ago

Putting the category breakdown at the end of the tooltip makes sense to me.