Closed julienw closed 6 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.44%. Comparing base (
1507cdd
) to head (a457ad3
). Report is 17 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @julienw -- this seems to work very well for me!
I've asked the necko folks to add feedback as well.
• The output didn't seem to be recognized by logan -- there might be a small export change required (this is a guess)
Current export: [Parent Process 158395 Socket Thread] D/nsSocketTransport engaging
But when I capture MOZ_LOG
's natively: [Parent 87530: Socket Thread]: D/nsSocketTransport engaging
• Naturally a button or similar would be better than console commands :) • I didn't find the performance to be a problem at all.
I've looked at the output log and it looks great! Thank you.
Thanks all, I made the requested changes and added a test! I also tested after the changes that logan would be able to import the resulting file.
This should now be ready for review :-)
deploy preview
One can use it this way:
This takes into account the current range (both selection range and committed range).
It is a little bit slow because running inside the web console runs the code only in the JS interpreter and never starts the JIT (I think). But I think it's still OK.
Fixes #4660