Closed fqueze closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.46%. Comparing base (
ffe2b6a
) to head (1a18805
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review!
I'm not super happy about this duplication, but let's do that...
I'm not super happy about the duplication either. I initially wanted to make a shared method returning timeAtViewportLeft and timeAtViewportRightPlusMargin, but then I realized some of the intermediary variables are used for the other caller, so I wouldn't actually win much.
Fixes a bug in the implementation of #4892.
Steps to reproduce: