search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Add sanitized-string format #5007

Closed valenting closed 3 weeks ago

valenting commented 1 month ago

See ⚙ D211171 Bug 1898171 - Add SanitizedString profiler marker format r=acreskey,julienw

This change adds the ability to sanitize fields that are not URLs or FilePaths. This is necessary when we want to add domains or other PII fields that are not exactly the same as URL or FilePath.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.49%. Comparing base (15336cc) to head (4fe78ba).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5007 +/- ## ======================================= Coverage 88.48% 88.49% ======================================= Files 304 304 Lines 27393 27398 +5 Branches 7400 7402 +2 ======================================= + Hits 24240 24245 +5 Misses 2931 2931 Partials 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

valenting commented 3 weeks ago

@julienw appveyor failed because of a nvm issue. The gecko patches are ready to land at your convenience.

valenting commented 3 weeks ago

Seems all green now.

julienw commented 3 weeks ago

appveyor isn't marked as "required" here, esp because it tends to fail sometimes like you've seen. It's more here for our information. Landing now, thanks again!