firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Update fake-indexeddb 5.0.2 → 6.0.0 (major) #5011

Closed depfu[bot] closed 4 weeks ago

depfu[bot] commented 1 month ago

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ fake-indexeddb (5.0.2 → 6.0.0) · Repo · Changelog

Release Notes

6.0.0

I made this a new major version because it includes a few changes that could in theory break something in some weird situations. But I think the vast majority of users (possibly all users?) won't have any issue upgrading.

  • #48 - Switched to using DOMException errors rather than normal errors, since that's what the IndexedDB spec says to use, and Node.js now has a built-in DOMException in all supported versions.

  • #93 - @bryan-codaio made the latest tweak to event scheduling, this time improving how setImmediate is used in some situations where people are mocking timers.

  • #99 - @sjnho fixed handling of Date objects to account for some edge cases, including jsdom overriding the native Date constructor.

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 10 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)
julienw commented 1 month ago

ping @canova about https://github.com/firefox-devtools/profiler/pull/4877 ;-)

canova commented 4 weeks ago

Oops thanks for reminding me @julienw! I just landed that one, let's rebase this.

@​depfu rebase

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.48%. Comparing base (579e273) to head (4f4287e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5011 +/- ## ======================================= Coverage 88.48% 88.48% ======================================= Files 304 304 Lines 27393 27393 Branches 7400 7400 ======================================= Hits 24240 24240 Misses 2931 2931 Partials 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.