search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Update github handle from AdamHarries to AdamBrouwersHarries #5014

Closed AdamBrouwersHarries closed 4 weeks ago

AdamBrouwersHarries commented 4 weeks ago

I changed my github username, and now none of the links work, and my avatar is broken, in CONTRIBUTING.md. This PR updates my github username in CONTRIBUTING.md.

canova commented 4 weeks ago

Could you run yarn prettier-fix to fix the prettier warnings and update the PR? We also have a pre-push hook that checks these before pushing, so you can catch these earlier. You might need to install the dependencies with yarn or yarn install before though.

AdamBrouwersHarries commented 4 weeks ago

We also have a pre-push hook that checks these before pushing, so you can catch these earlier.

It turns out I didn't have yarn installed (which was a surprise), so the pre-push hooks didn't run. Fixed now though!

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.48%. Comparing base (5ac4665) to head (b382cc1).

:exclamation: Current head b382cc1 differs from pull request most recent head 920ef03

Please upload reports for the commit 920ef03 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5014 +/- ## ======================================= Coverage 88.48% 88.48% ======================================= Files 304 304 Lines 27393 27393 Branches 7400 7400 ======================================= Hits 24240 24240 Misses 2931 2931 Partials 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.