firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Markers drawn in the stack chart are not very visible when they're small #5019

Open julienw opened 3 weeks ago

julienw commented 3 weeks ago

Here is an example: https://share.firefox.dev/3x6ebx8 from https://phabricator.services.mozilla.com/D212717

I think the issue is that this was implemented by making the markers drawn by the stack chart implementation. Instead I think we should use the marker chart implementation in its own separate canvas. The nice consequences would be that the marker design would be the same, and we'd get the context menus and tooltips (see also #2354, #2355) for free.

I don't know how hard or easy this would be though. It would need some additional investigation to estimate the complexity.