firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Filter marker schema with an empty "graphs" array out of the custom tracks area #5020

Closed julienw closed 3 weeks ago

julienw commented 3 weeks ago

With this PR, when the local tracks are computed, marker schemas with a graphs property that is an empty array are silently skipped. Previously only schemas without a graphs property were skipped.

This should fix the crash in #4818, but the script that generates the data should be fixed as well.

I added a test as the first commit so that we can see the change in the second commit.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.49%. Comparing base (a43a86c) to head (c0c32c3).

:exclamation: Current head c0c32c3 differs from pull request most recent head 9b40024

Please upload reports for the commit 9b40024 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5020 +/- ## ======================================= Coverage 88.49% 88.49% ======================================= Files 304 304 Lines 27398 27400 +2 Branches 7402 7404 +2 ======================================= + Hits 24245 24247 +2 Misses 2931 2931 Partials 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.