Closed depfu[bot] closed 2 weeks ago
https://github.com/reduxjs/reselect/issues/635 still doesn't seem fixed. It would be good to look at the impact for us, and if we need to implement https://github.com/reduxjs/reselect/issues/635#issuecomment-1850350607 for all or some of our selectors. Normally this should be handled in reselect's code in https://github.com/reduxjs/reselect/blob/2d17a06720c15aab52f682c42de909df5041d9a5/src/weakMapMemoize.ts#L205-L209 but it would be good to double check our memory usage with the new version.
Updating reselect is therefore a significant work for us without a clear improvement, so I'm not in a rush to update it...
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ reselect (4.1.8 → 5.1.1) · Repo · Changelog
Release Notes
5.1.1
5.1.0
5.0.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by more commits than we can show here.
Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase
.All Depfu comment commands