firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

The marker field-based search should match field labels as well #5029

Open julienw opened 2 weeks ago

julienw commented 2 weeks ago

Currently the field-based search needs that the user knows the field name to match. But it's impossible for a user to know them as they don't appear in the UI.

Instead we should match the labels, as a substring preferably because some labels have spaces and we don't support using quotes to match spaces currently. My preference would be to do only match the label and stop matching the field name that have no UI reality, but Nazım would prefer to match both for backward compatibility. I don't have a super strong opinion so I'm fine with Nazım approach.