firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Persist tooltips when the items (marker, frame) are selected #5039

Closed canova closed 2 days ago

canova commented 1 week ago

With this PR, after you click on a marker or a frame, it should persist the tooltip until somewhere else closed so we can click on links or copy text easily.

Profile with markers that have a url: Before / After

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 77.77778% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.47%. Comparing base (f232350) to head (ca29b50).

Files Patch % Lines
src/components/shared/chart/Canvas.js 81.25% 3 Missing :warning:
src/components/tooltip/Tooltip.js 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #5039 +/- ## ========================================== - Coverage 88.48% 88.47% -0.01% ========================================== Files 304 304 Lines 27423 27432 +9 Branches 7413 7416 +3 ========================================== + Hits 24264 24270 +6 - Misses 2934 2937 +3 Partials 225 225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.