Closed canova closed 5 days ago
Attention: Patch coverage is 71.42857%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 88.56%. Comparing base (
6489759
) to head (31851a6
). Report is 3 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/profile-logic/profile-data.js | 63.63% | 4 Missing :warning: |
src/selectors/profile.js | 80.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for the review!
2 quick questions:
it would be good to have an indicator in the list that they are addons (maybe reusing the addons icon?)
also show the addons icon instead of the favicon
Good questions. We can do them as follow-ups.
Previously it was not possible to see the real extension names and they were always written like "UUID" because of it. With this PR, we get the correct extension names from the
profile.extensions
array and display them properly.It also had a bug previously. When we try to construct a URL object with
moz-extension://
protocol, it was failing outside of Firefox, it was returning'null'
for the origin and hostname, which was crashing in the code since we were trying to use it for something else afterwards. This PR makes sure that it doesn't crash on non-Firefox browsers and always return the proper name for the extensions.Deploy preview