firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.22k stars 397 forks source link

Make it possible to share a profile even before symbolication #711

Open julienw opened 6 years ago

julienw commented 6 years ago

This is useful for users on slow machine.

2 possibilities:

(requested by @fqueze)

┆Issue is synchronized with this Jira Task

digitarald commented 6 years ago

Per #1325, the easiest way forward would be allowing cancellation of the symbolication, which in turn will enable the share button.

zoepage commented 6 years ago

+1 in adding a button to cancel the symbolication. Do we also need to adjust the message Symbolicating call stacks... and make it more human understandable as users might not understand what this is / why it is helpful?

digitarald commented 6 years ago

Make sense, especially when dogfooding users on the internet see this. We can keep the technical information in an alt tooltip (and maybe a learn more link with troubleshooting in the doc? we should do more of that for interesting parts of the UI that benefit from hints).

Friday vote time …

1️⃣ Processing Profile … 2️⃣ Loading profile information … 3️⃣ Reticulating splines … 4️⃣ Enhancing!

fqueze commented 6 years ago

3️⃣ Reticulating splines … 4️⃣ Enhancing!

Not sure if these 2 are purely a joke or semi-serious, but IMO replacing a message that's opaque to most users and meaningful to a few with a message that's opaque to everybody wouldn't be an improvement.

I don't really mind which phrasing we use, as long as it remains visible if we are blocked on getting the symbols (this happens with slow Internet connections, or when nm takes ages on a local build) or on applying them.

julienw commented 6 years ago

Counter-proposition: 5️⃣ Fetching additional information… ?

digitarald commented 6 years ago

I don't really mind which phrasing we use, as long as it remains visible if we are blocked on getting the symbols (this happens with slow Internet connections, or when nm takes ages on a local build) or on applying them.

Good point.

Counter-proposition: 5️⃣ Fetching additional information… ?

I had that as an iteration of 2️⃣when I wrote it up, I like that too with the only downside is that it doesn't fully highlight the dependency on network bandwidth and server response time (compared to Loading). Maybe Downloading additional profile information …?

julienw commented 6 years ago

Ah, this is funny :) for me the meaning for fetch is closer to a network-downloading than load :) I'd be OK with Downloading.

fqueze commented 5 years ago

I think sharing is possible before the end of symbolication with the new sharing flow. Is there more we want to do here, or should we just close this issue?

julienw commented 5 years ago

I think the main issue has been fixed indeed. That said, do we still want to change the symbolication text?