Open julienw opened 6 years ago
Per #1325, the easiest way forward would be allowing cancellation of the symbolication, which in turn will enable the share button.
+1 in adding a button to cancel the symbolication.
Do we also need to adjust the message Symbolicating call stacks...
and make it more human understandable as users might not understand what this is / why it is helpful?
Make sense, especially when dogfooding users on the internet see this. We can keep the technical information in an alt
tooltip (and maybe a learn more link with troubleshooting in the doc? we should do more of that for interesting parts of the UI that benefit from hints).
Friday vote time …
1️⃣ Processing Profile …
2️⃣ Loading profile information …
3️⃣ Reticulating splines …
4️⃣ Enhancing!
3️⃣
Reticulating splines …
4️⃣Enhancing!
Not sure if these 2 are purely a joke or semi-serious, but IMO replacing a message that's opaque to most users and meaningful to a few with a message that's opaque to everybody wouldn't be an improvement.
I don't really mind which phrasing we use, as long as it remains visible if we are blocked on getting the symbols (this happens with slow Internet connections, or when nm takes ages on a local build) or on applying them.
Counter-proposition: 5️⃣ Fetching additional information…
?
I don't really mind which phrasing we use, as long as it remains visible if we are blocked on getting the symbols (this happens with slow Internet connections, or when nm takes ages on a local build) or on applying them.
Good point.
Counter-proposition: 5️⃣ Fetching additional information… ?
I had that as an iteration of 2️⃣when I wrote it up, I like that too with the only downside is that it doesn't fully highlight the dependency on network bandwidth and server response time (compared to Loading). Maybe Downloading additional profile information …
?
Ah, this is funny :) for me the meaning for fetch
is closer to a network-downloading than load
:)
I'd be OK with Downloading
.
I think sharing is possible before the end of symbolication with the new sharing flow. Is there more we want to do here, or should we just close this issue?
I think the main issue has been fixed indeed. That said, do we still want to change the symbolication text?
This is useful for users on slow machine.
2 possibilities:
(requested by @fqueze)
┆Issue is synchronized with this Jira Task