search

firefox-devtools / profiler

Firefox Profiler — Web app for Firefox performance analysis
https://profiler.firefox.com
Mozilla Public License 2.0
1.14k stars 372 forks source link

Selected and expanded node paths are not transformed when popping a transform #882

Open julienw opened 6 years ago

julienw commented 6 years ago

Currently we don't transform selected and expanded node paths back when popping a transform.

I don't think this would be easy to "compute" all the expanded paths in that case, so I think there are 2 possible paths here:

  1. remember what the state was before adding the transform.
  2. only consider the selected path and expand the tree up to this selected path

┆Issue is synchronized with this Jira Task

gregtatum commented 6 years ago

I'm taking off the bug label, as it was the intended behavior when I implemented it. Pushing and popping a transform will potentially result in a different set of call node paths, as they have different meanings. Plus implementing the reverse of the filters sounds like a hard problem.

I think remembering the state before adding the transform would be reasonable though.