RDM toolbar icons - Githubissues

firefox-devtools / ux

Firefox DevTools UX Community

Mozilla Public License 2.0

103 stars 21 forks source link

RDM toolbar icons #28

Closed violasong closed 5 years ago

violasong commented 5 years ago

(assigned to Yash)

This is a bug to track work on the toolbar icons, including rotate, touch, and screenshot.

violasong commented 5 years ago

Latest variants from Yash:

violasong commented 5 years ago

The rotate icon is awesome and ready to go! (we discussed before that the icon itself could represent the current rotation)

The touch icon is getting really close — I think it's still just a tiny bit too abstract in style and could use some photon-ization. Ideas:

Fill in the hand so that it's dark
Adding 3 little bumps for the folded fingers, giving a bit more separation for the thumb, and slight rounded corners for the "wrist" could help make it look a bit more clearly hand-like
Maybe the semi-circle for touch could actually be a line or a less rounded curve? (to make the perspective a bit flatter)

yashjohar commented 5 years ago

Thanks Victoria! Those are some really good ideas. I'll see if the hand can be made a little less abstract.

yashjohar commented 5 years ago

The new hand icon: rmd-toolbar-icons Let me know what you think. Thanks!

violasong commented 5 years ago

Hi Yash! So sorry for the delay. I really like the changes you made - I just have a few more suggestions if you don't mind. I quickly drew over your latest version in photoshop to show the ideas - wider at top of fist and narrower at the bottom, rounder and taller fist, and more finger definition.

small:

large:

I also tried filling it in for photon but it seemed a lot less clear. I think sticking with the lighter version is fine for this secondary style of toolbar.

fvsch commented 5 years ago

@yashjohar Do you happen to have your icons in SVG?

For screenshots, bug 1517189 implements a new camera icon (see #36), so we should probably just use that.

yashjohar commented 5 years ago

Thanks for the feedback @violasong . Below screenshot has the redone hand icon inspired by your drawing: touch-events-hand touch-events-hand-2x @fvsch the new toolbox icons look great. I used the camera icon (option 1) from the attachment. I have the other two RDM icons in SVG.

violasong commented 5 years ago

Hey @yashjohar! I really like your latest hand icon! Thanks for trying the new idea :D

yashjohar commented 5 years ago

Thanks @violasong. Is there a bug for implementation?

violasong commented 5 years ago

Hey Yash! Looks like it would be best to make a new bug for both this and the rotate icon.

fvsch commented 5 years ago

@yashjohar I opened bug 1535254 on Bugzilla. Do you have an account there, so that I can assign you to the issue? Or do you need help with the implementation?

yashjohar commented 5 years ago

@violasong I have a Bugzilla account yash.johar1992@gmail.com. You can assign the bug to me. Thanks!

yashjohar commented 5 years ago

Hi @violasong @fvsch sorry for the delay. I have attached the rotate and touch icons to the bug 1535254. I don't have a copy of Illustrator and will need some help optimising them.

violasong commented 5 years ago

No worries and thanks @yashjohar! Excited to see these land.