search

firefox-devtools / ux

Firefox DevTools UX Community
Mozilla Public License 2.0
103 stars 21 forks source link

Align Inspector toolbar height with other panels #52

Closed fvsch closed 5 years ago

fvsch commented 5 years ago

The Inspector's top toolbar is currently 23px tall (excluding borders). We have a bug on file for making it 24px tall with a patch, but I'm wondering if we should just align it with Console, Network, Debugger, Accessibility and use a 28px height instead?

With the bigger and fatter Photon icons, 24px can look a bit cramped, and it could be nice to be consistent here.

Accordion headers and the breadcrumbs could remain 24px.

Here's what a quick test looks like (please disregard the breadcrumbs):

inspector-toolbar-28px

Pinging @violasong @captainbrosset @gabrielluong.

captainbrosset commented 5 years ago

I like it. Consistency is the most important.

violasong commented 5 years ago

Interesting, thanks for bringing this up! I think this will make a lot of sense, especially since we are planning to do more with that markup view toolbar, with filter badges similar to Console/Network.

oslego commented 5 years ago

Agreed. It looks more elegant, especially with the redesigned search/filter input fields.

fvsch commented 5 years ago

I'm working on it in bug 1535956.

fvsch commented 5 years ago

Closing this since we have a UX decision already, and work underway.