search

firegento / firegento-adminmonitoring

Monitor all activities in the backend and provide a history about the changes.
GNU General Public License v3.0
91 stars 23 forks source link

Unit tests are broken #36

Closed pogster closed 5 years ago

pogster commented 6 years ago

Because the version number was raised to 1.2.3, the test for 1.2.2 fails (see app/code/community/FireGento/AdminMonitoring/Test/Config/expectations/globalConfig.yaml). (What's the point of such a test anyway?)

FireGento_AdminMonitoring_Test_Config_Config::globalConfig
Failed asserting that 1.2.2 module version is equal to 1.2.2.
--- Expected
+++ Actual
@@ @@
-'1.2.2'
+'1.2.3'

/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:241
/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:226
/project/lib/EcomDev/PHPUnit/Constraint/AbstractConfig.php:76
/project/lib/EcomDev/PHPUnit/Constraint/Config.php:108
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:210
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:814
/project/app/code/community/FireGento/AdminMonitoring/Test/Config/Config.php:35
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/TestRunner.php:25
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/Command.php:13
/project/vendor/fiunchinho/phpunit-randomizer/bin/phpunit-randomizer:20
pogster commented 6 years ago

I justed noticed that a follow up test would also be broken...

1) FireGento_AdminMonitoring_Test_Config_Config::globalConfig
Failed asserting that setup resources scheme setup scripts are created in correct version chain order.
--- Expected
+++ Actual
@@ @@
 upgrade-1.2.1-1.2.2.php
-upgrade-1.2.2-1.2.3.php

/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:241
/project/lib/EcomDev/PHPUnit/AbstractConstraint.php:226
/project/lib/EcomDev/PHPUnit/Constraint/AbstractConfig.php:76
/project/lib/EcomDev/PHPUnit/Constraint/Config.php:108
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:210
/project/app/code/community/EcomDev/PHPUnit/Test/Case/Config.php:379
/project/app/code/community/FireGento/AdminMonitoring/Test/Config/Config.php:39
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/TestRunner.php:25
/project/vendor/fiunchinho/phpunit-randomizer/src/PHPUnitRandomizer/Command.php:13
/project/vendor/fiunchinho/phpunit-randomizer/bin/phpunit-randomizer:20