firegento / firegento-germansetup

FireGento_GermanSetup
61 stars 27 forks source link

EU Setup? #180

Closed amenk closed 11 years ago

amenk commented 11 years ago

What about EU specific changes?

i.e. I am thinking about adding an option to remove the tax-display (show only the shipping link) - as it looks like in Italy we shall not show that.

Would such an option make sense for Germany as well? Or should be better make a for EU-Setup :-) ?

Might be interesting, as there are some unified laws going on concerning online shopping in EU.

Are there any plans for that?

Do you know about similar projects like German Setup in the EU ?

avstudnitz commented 11 years ago

I like the idea of a european / international setup. In my opinion, it'd be the right next step for us. We'd need to add some more configurations (mostly tax-specific). What are our options?

  1. Extend GermanSetup, keep the name, just make it usable in more european countries
  2. Rename it to EuropeanSetup, InternationalSetup or something like that
  3. Make a fork and rename it there

I'd prefer option 3, although option 1 provides much better maintainability for changes made in GermanSetup.

As I am working on more country distributions like Magento DE, Magento AT and Magento CH, I am willing to do a bigger part of that.

gfobe commented 11 years ago

Variant 1 Pros:

Cons:

Variant 2 Pros:

Cons:

Variant 3 Pros:

Cons:

therouv commented 11 years ago

I'd vouch for option 1 mainly because of the following reasons:

The name should be changed though. Kind of like "MageSetup" or sth. like that.

avstudnitz commented 11 years ago

Okay, as there seem to be no further (differing) opinions, I'd like to start to work on the (sub-)project today. I like the name "MageSetup" for the package. @therouv, could you create a new repository with the new name for that? For now until the release, we can of course use a branch of this repository ("mage-setup").

Once I started work, I can better identify the to-dos.

therouv commented 11 years ago

@avstudnitz Please see https://github.com/firegento/firegento-magesetup

avstudnitz commented 11 years ago

Thanks :-) Work has begun, will be ready to be tested soon.