search

firegento / firegento-magesetup

MageSetup
GNU General Public License v3.0
120 stars 81 forks source link

Change price presicion to 4? #346

Open sreichel opened 5 years ago

sreichel commented 5 years ago

Magesetup is made for localized market, so I hope this could move in ;)

Our settings:

This breaks correct price calculation for carts with multiple items and leads to "Supected fraud" errors for Paypal payments. With changing presion to 4 we could nealy solve most of this ... only Paypay needs an additionl fix for 0,01€ rounding.

W/o paypal fix ... https://magento.stackexchange.com/a/270713/46249

Ideas?

Schrank commented 5 years ago

Good morning, unfortunately I haven’t fibd a proper fix until now, because we don’t know how PayPal is doing it’s calculations exactly.

If you don’t submit cart line items, this solves the problem but kills seller protection.

Which Magento version are you running on? The current has much lower probability for rounding issues. But it isn’t fixed.

Schrank commented 5 years ago

There is a module you might want to try/ PR int: https://github.com/magento-hackathon/PaypalRoundBugfix

Schrank commented 5 years ago

Obviously the module isn’t doing what I hoped, but improving it is a thing 😂

sreichel commented 5 years ago

If you don’t submit cart line items, this solves the problem but kills seller protection.

Which Magento version are you running on? The current has much lower probability for rounding issues. But it isn’t fixed.

Good morning ;) We use 1.9.4.x (LTS) and work with 4 decimals since 1.5. If i remember right PayPal issues came with 1.9. We've "fixed" it similiar to this https://www.kreativundsoehne.de/blog/magento-rundungsfehler-in-version-1-9-x.html (check if diff is 0,01€ and adjust paypal value)