firegento / firegento-magesetup

MageSetup
GNU General Public License v3.0
120 stars 81 forks source link

improved antispam exclusion for order mail sending #349

Closed sprankhub closed 5 years ago

Schrank commented 5 years ago

May you explain, what the change should do, I'm not sure I understand it completely :D

sprankhub commented 5 years ago

Sure. We have an antispam functionality, which replaces mail addresses with some ugly JS, so hopefully bots to not get the mail addresses. This is generally a good idea. However, this antispam JS should NOT be used in e-mails, because spam filter will then likely mark them as spam. Hence, we excluded the antispam JS for some actions. However, it turned out that this only worked for PayPal Express orders (area frontend and action placeOrder). I simply extended this, so that the cases "normal checkout" and "send order mail via admin" are also handled.