firegento / firegento-magesetup2

MageSetup for Magento2
GNU General Public License v3.0
120 stars 72 forks source link

Fix PHPCS issues, fixes #196 #197

Closed sprankhub closed 3 years ago

sprankhub commented 3 years ago

Please make sure these boxes are checked before submitting your PR - thank you!

Issue

This PR fixes issue #196.

Proposed changes

...

sprankhub commented 3 years ago

@Schrank, @frostblogNet, @mautz-et-tong, could anyone please have a look?

in-session commented 3 years ago

Hi after update into the new merge on Magento 2.4.2 we get the follow error:

1 exception(s):
Exception #0 (Magento\Framework\Exception\LocalizedException): Ungültige Methode FireGento\MageSetup\Block\Product\Delivery\Interceptor:: helper

Exception #0 (Magento\Framework\Exception\LocalizedException): Ungültige Methode FireGento\MageSetup\Block\Product\Delivery\Interceptor:: helper
<pre>#1 FireGento\MageSetup\Block\Product\Delivery\Interceptor->__call() called at [vendor/firegento/magesetup2/view/frontend/templates/product/list/delivery.phtml:16]

magesetup2/view/frontend/templates/product/list/delivery.phtml:16:

//$_helper = $block->helper('Magento\Catalog\Helper\Output');
$_helper = $this->helper(Magento\Catalog\Helper\Output::class);