shouldAddPriceDetails() to public

firegento / firegento-magesetup2

MageSetup for Magento2

GNU General Public License v3.0

120 stars 72 forks source link

shouldAddPriceDetails() to public #210

Closed Cloudy777 closed 2 years ago

Cloudy777 commented 2 years ago

General

Module version: v1.1.2

Issue description

Would it be possible to change Plugin/Pricing/AddPriceDetailsPlugin.php::shouldAddPriceDetails() from private to public? We want to modify when the price details are rendered (some product don't need them). A plugin here would be the best way imo. We can do a pull request if needed. What do you think?

frostblogNet commented 2 years ago

Hello @Cloudy777

there is no reason why this method is private so a pull request would be nice.

Thanks

frostblogNet commented 2 years ago

Thanks for contribution.