[FEATURE] display attribute value of child product in cart

firegento / firegento-magesetup2

MageSetup for Magento2

GNU General Public License v3.0

120 stars 72 forks source link

[FEATURE] display attribute value of child product in cart #214

Open rommelfreddy opened 1 year ago

rommelfreddy commented 1 year ago

Please make sure these boxes are checked before submitting your PR - thank you!

[x] Pull request is based against develop branch
[x] README.md reflects changes (if applicable)
[x] New files contain a license header

Issue

none

Proposed changes

this PR prints the child-attribute value in the cart instead of the configurable attribute value. This makes more sense, cause the admin would change the value in the child below. E.g. the SKU.

sprankhub commented 1 year ago

Thanks for your contribution, @rommelfreddy! Could you check my comments and the failing pipeline?

I think the change makes sense, but I would love to get a second opinion from e.g. @frostblogNet :)

frostblogNet commented 1 year ago

@rommelfreddy thanks for the contribution. It would be nice if you could change the line metioned by @sprankhub. Sorry for the late response.

sprankhub commented 10 months ago

@roman204, if you want to push this forward, feel free to send a new PR with the changes fixed. Since I don't need this at the moment and my time is very limited, I cannot just work on this.