search

firegiant / HeatWaveSupport

Issues-only repository to report HeatWave bugs and feature requests to FireGiant
3 stars 0 forks source link

Project references with non-ASCII characters in project name fail #47

Open Arinluna opened 10 months ago

Arinluna commented 10 months ago

HeatWave Version

1.0.2

Visual Studio Version

17.7.6

Repro Steps

  1. Add any project to the solution with a name that contains a non-ASCII character. For example: 'ű'
  2. Add said project as a project reference to the installer project
  3. Try to build Addendum: The original .wixproj was updated from WIX v3 using HeatWave. I know that WIX v3 is not WIX v4, but WIX v3 was able to build the .msi using the original non-ACSII project names.

Actual Result

error WIX0150: Undefined preprocessor variable '$(var.AdatGyűjtőSvc.TargetDir)'

Expected Result

A succesfuly built .msi package, since the source project builds correctly. Or, the very least, an error message that is relevant to the actual issue. I don't think that: "Undefined preprocessor variable $(var.MyNonAsciiProjectName.TargetDir)" is the relevant message, since some other component had to fail to create that variable in the first place.

firegiantco commented 8 months ago

We are not able to reproduce this issue. Can you provide a sample solution that demonstrates the error please?

Arinluna commented 8 months ago

Sample.zip The sample is the recreation of the structure of the solution with my original issue. Package.wxs should be the same as in the original solution (adjusted to the older project names). The sample should also contain a screenshot with the messages. HeatWave version is still 1.0.2 Visual Studio is version 17.7.7 now