Feature/customize column header

[bdzzaid]

This feature is expected to manage I18n column names. Can you please review and let me know if any update is needed.

I hope you can quickly release it

[bdzzaid]

Hi @firegloves

I checked the failure on "Build and Test / Codacy Analysis CLI" step. It seems due to an authentication issue to codacy plateform.

Can you check from your side please ?

Thks Zaïd

[firegloves]

Hi @bdzzaid,

I added some comments in the review. However good job, thx for the contribution :) I have only to ask you to add some integration tests. In my opinion we need at least these tests:

• supplying some column display name and no AS clauses, they should be correctly applied
• supplying some column display names and some AS clauses, they should be all correctly applied
• supplying some column display names and some AS clauses (clashing each other), they should be correctly applied (which is the precedence order? Reading at the code is the newly added field. It is right in my opinion, but we want to enforce it for possible future regressions)

If you can, please improve the unit test already written, passing also a null value to the builder. I know that's already managed, but it could help to prevent regressions.

For integrations tests, you can find a docker environment in the docker_data folder. It is already configured, just start it and copy-paste an already existing class: it will be using the docker DB. The AssertionHelper class is a bit tricky to use, I should refactor it a bit. You can find there some examples to validate the generated files, but if you encounter too many difficulties I can take care to complete the integration tests. But these ones are demanding days at work and I have no time to work on Mempoi, so if you need it as soon as possible, consider spending a bit of time on this task

Don't worry about the code analysis, I don't know right now how to propagate the missing credentials, but:

• I'm running the analysis manually from the codacy web console.
• I can merge with administrator privileges

Thx again for your work!