Closed jweissman closed 11 years ago
Okay, so this seems to be about some recent changes to em-hiredis
-- rolling back to the previous version (before 0.2.0) seems to have changed it. Looks like this was changed in the last few days. Anyway, closing my issues for the time being.
Interesting, do you have a link to the changes in em-redis that caused the problem?
I filed this issue report with them, which was closed (and they outlined the changes that would need to be made, more or less) -- https://github.com/mloughran/em-hiredis/issues/24
It looks like most of the changes are in em-hiredis' client.rb
; my sense is that the API really just changed a little bit, but enough to break older clients.
To be clear I only really caught up to what was going on because the new release was really recent -- like three days ago! -- and because the delta on em-redis' client.rb
between 0.1.1 and 0.2.0 clearly indicated the error that I was seeing.
Pretty sure this is the culprit but haven't dug incredibly deeply here:
https://github.com/mloughran/em-hiredis/commit/e44078c1e0c47bfef1095066b98136bfc596c5d4
Did you end up patching this to deal with the 2.0 changes or pegging em-hiredis to 1.x?
Pegged em-hiredis to 1.x for the time being (just to permit local development to move forward).
Sorry if this is noisy/overlaps with the other issue I've filed but I just wanted to be clear about my core issue, which isn't with CORS in particular; it's that I can't even get the basic
curl
subscription behavior from thefirehose server
example on the homepage.On the curl side, when I try to
curl "http://localhost:7474/hello", I get a
curl: (52) Empty reply from server` error, and curl exits. On the firehose side, I am seeing the following in the logs: