search

firehoseio / firehose

Build realtime Ruby web applications. Created by the fine folks at Poll Everywhere.
http://firehose.io/
MIT License
727 stars 72 forks source link

Travis CI build is failing #20

Closed bradgessler closed 11 years ago

bradgessler commented 11 years ago

I can verify the same specs on Travis CI are failing locally. https://travis-ci.org/polleverywhere/firehose/jobs/5085390

bradgessler commented 11 years ago

I've tracked this down to something that's going on with WebSockets. I think newer versions of Rack + Rainbows are not playing nice with Faye::WebSockets.

thoughtless commented 11 years ago

I believe the problem is that we aren't sending {'message_sequence':0} and that is now required. https://github.com/polleverywhere/firehose/blob/master/spec/integrations/shared_examples.rb#L70

https://github.com/polleverywhere/firehose/blob/master/lib/firehose/rack/consumer_app.rb#L132

thoughtless commented 11 years ago

Should be fixed by https://github.com/polleverywhere/firehose/commit/b3eb05a2f232d3924af820064d3559a8e70fe539

I'll hold off closing this until TravisCI is actually passing.

thoughtless commented 11 years ago

The problem is that a couple of gems weren't having their versions specified. Firehose isn't compatible with the latest versions of Rainbows! and em-hiredis. For now I have pegged the versions. I'll open two more issues for upgrading those gems.