Update: LongPoll initialization to handle missing constants

firehoseio / firehose

Build realtime Ruby web applications. Created by the fine folks at Poll Everywhere.

http://firehose.io/

MIT License

726 stars 72 forks source link

Update: LongPoll initialization to handle missing constants #27

Closed jweissman closed 11 years ago

jweissman commented 11 years ago

This pull request modifies the browser check at the end of LongPoll to include a verification of whether $.browser.msie is even defined.

For some context/motivation: this was causing issues for me and became pronounced when I tried to enable the asset pipeline (it wouldn't load any subsequent modules after throwing a ReferenceError here.)

bradgessler commented 11 years ago

Thanks for the patch! I tightened it up a bit via https://github.com/polleverywhere/firehose/commit/abd973b31f917d62e9201897ae8ea1fc33eaa75b

Pull gem 1.2.3 and you should be all set.