search

firehoseio / firehose

Build realtime Ruby web applications. Created by the fine folks at Poll Everywhere.
http://firehose.io/
MIT License
727 stars 72 forks source link

add 'rainbows' gem to gemspec #33

Closed thewatts closed 10 years ago

thewatts commented 10 years ago

ran gem install firehose and then firehose server - but got an error:

cannot load such file -- rainbows (LoadError)

After installing the rainbows gem, things worked fine.

Adding to gemspec so that it can be installed and run w/out the manual rainbows installation.

thoughtless commented 10 years ago

Rainbows is intentionally left out because it is not required if you are using thin as your webserver. The opposite is also true; you don't need the thin gem if you are using rainbows.

thewatts commented 10 years ago

Ahh, okay!

My apologies then! — Sent from Mailbox for iPhone

On Fri, Jan 10, 2014 at 12:00 AM, Paul Cortens notifications@github.com wrote:

Rainbows is intentionally left out because it is not required if you are using thin as your webserver. The opposite is also true; you don't need the thin gem if you are using rainbows.

Reply to this email directly or view it on GitHub: https://github.com/polleverywhere/firehose/pull/33#issuecomment-32006729

bf4 commented 10 years ago

Shouldn't there be a warning and exit if no thin or rainbows, rather than a load error?

thoughtless commented 10 years ago

Yeah. That would probably be best. Catch the load error and print out a warning before exiting.

bradgessler commented 10 years ago

:+1:

andrewhamon commented 9 years ago

Yeah it would be great if the getting started section on the homepage actually worked/mentioned this.

bradgessler commented 9 years ago

@andrewhamon could you edit the README.md where this would have helped and open a PR? I'll merge it.

andrewhamon commented 9 years ago

@bradgessler By home page i meant the home page at http://firehose.io